Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NHUB-583] fix(celery): Await when sending task to celery #1157

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[NHUB-583] fix(celery): Await when sending task to celery #1157

merged 3 commits into from
Nov 12, 2024

Conversation

MarkLark86
Copy link
Contributor

@MarkLark86 MarkLark86 commented Nov 11, 2024 •
edited
Loading

Purpose

Sending tasks to celery was not working, as the task sending itself was not awaited (therefor never executed in event loop).

What has changed

  • Add await when sending task to celery
  • Enable tests for unit tests that require celery, that we previously disabled (before async celery was supported)
  • Fix unit tests

@MarkLark86 MarkLark86 added this to the v3.0 milestone Nov 11, 2024
devketanpro
devketanpro approved these changes Nov 12, 2024
View reviewed changes
newsroom/reports/content_activity.py Outdated Show resolved Hide resolved
@MarkLark86 MarkLark86 merged commit dc55efd into superdesk:async Nov 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devketanpro devketanpro devketanpro approved these changes

Assignees
No one assigned
Labels
async
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkLark86 @devketanpro